Changes for Ascent Tests (ECP CI)

- Removing test exclusions since they seem to be passing
- Adding macros for PowerPC to exclude poor FMA tests
  (`vtkm::DiffernceOfProducts` on Power 9 using FMA produces the same result as
   `a*b - c*d`, when ideally it's expected to produce a more accurate result)
This commit is contained in:
Abhishek Yenpure 2022-07-10 16:38:13 -07:00
parent b4e6370e9e
commit bb37282d25
2 changed files with 2 additions and 10 deletions

@ -74,14 +74,6 @@ test:ascent_gcc_cuda:
# Tests errors to address due to different env/arch in Ascent
# Refer to issue: https://gitlab.kitware.com/vtk/vtk-m/-/issues/652
CTEST_EXCLUSIONS: >-
UnitTestMathSERIAL
UnitTestMathCUDA
UnitTestSerialDeviceAdapter
UnitTestAverageByKeySERIAL
UnitTestKeysSERIAL
UnitTestWorkletReduceByKeySERIAL
RegressionTestAmrArraysSERIAL
RegressionTestAmrArraysCUDA
before_script:
# Prep the environment

@ -843,7 +843,7 @@ struct ScalarVectorFieldTests : public vtkm::exec::FunctorBase
VTKM_EXEC
void TestDifferenceOfProducts() const
{
#if defined FP_FAST_FMA && !defined __HIP__
#if defined FP_FAST_FMA && !defined __HIP__ && !defined _ARCH_PPC && !defined _ARCH_PPC64
// Example taken from:
// https://pharr.org/matt/blog/2019/11/03/difference-of-floats.html
vtkm::Float32 a = 33962.035f;
@ -882,7 +882,7 @@ struct ScalarVectorFieldTests : public vtkm::exec::FunctorBase
VTKM_MATH_ASSERT(vtkm::IsNan(roots[1]),
"Roots should be Nan for a quadratic with complex roots.");
#if defined FP_FAST_FMA && !defined __HIP__
#if defined FP_FAST_FMA && !defined __HIP__ && !defined _ARCH_PPC && !defined _ARCH_PPC64
// Wikipedia example:
// x² + 200x - 0.000015 = 0 has roots
// -200.000000075, 7.5e-8