mirror of
https://gitlab.kitware.com/vtk/vtk-m
synced 2024-09-19 18:45:43 +00:00
Revise TODO/FIXME comments
This commit is contained in:
parent
c584364122
commit
cc7c3b5a44
@ -598,7 +598,9 @@ inline VTKM_CONT void ContourTreeUniformDistributed::PostExecute(
|
|||||||
vtkm::cont::Timer timer;
|
vtkm::cont::Timer timer;
|
||||||
timer.Start();
|
timer.Start();
|
||||||
// We are running in parallel and need to merge the contour tree in PostExecute
|
// We are running in parallel and need to merge the contour tree in PostExecute
|
||||||
// TODO/FIXME: Make sure this still makes sense
|
// TODO/FIXME: This filter should only be used in a parallel setting with more
|
||||||
|
// than one block. Is there a better way to enforce this? thrown an exception
|
||||||
|
// instead of an empty return? What is the appropriate exception?
|
||||||
if (this->MultiBlockSpatialDecomposition.GetGlobalNumberOfBlocks() == 1)
|
if (this->MultiBlockSpatialDecomposition.GetGlobalNumberOfBlocks() == 1)
|
||||||
{
|
{
|
||||||
return;
|
return;
|
||||||
@ -1143,8 +1145,7 @@ VTKM_CONT void ContourTreeUniformDistributed::DoPostExecute(
|
|||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
// TODO/FIXME: For getting owned vertices, it should not make a difference if marching
|
// For getting owned vertices, it does not make a difference if we are using marching cubes or not.
|
||||||
// cubes or not. Verify.
|
|
||||||
vtkm::worklet::contourtree_augmented::DataSetMeshTriangulation3DFreudenthal mesh(b->Size);
|
vtkm::worklet::contourtree_augmented::DataSetMeshTriangulation3DFreudenthal mesh(b->Size);
|
||||||
hyperSweeper.InitializeIntrinsicVertexCount(
|
hyperSweeper.InitializeIntrinsicVertexCount(
|
||||||
b->HierarchicalContourTree, mesh, idRelabeler, b->IntrinsicVolume);
|
b->HierarchicalContourTree, mesh, idRelabeler, b->IntrinsicVolume);
|
||||||
|
Loading…
Reference in New Issue
Block a user