Shuenhoy/vtk-m
1
0
Fork 0
mirror of https://gitlab.kitware.com/vtk/vtk-m synced 2024-10-05 01:49:02 +00:00
Code Issues 2 Actions Packages Projects Releases Wiki Activity

simplify comment

Browse Source
This commit is contained in:
Li-Ta Lo 2023-05-15 13:05:06 -06:00
parent 066e6a6969
commit d05025ce85
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vtkm/rendering/ScalarRenderer.cxx
View File

@ -46,7 +46,7 @@ ScalarRenderer::ScalarRenderer(ScalarRenderer&&) noexcept = default;
ScalarRenderer& ScalarRenderer::operator=(ScalarRenderer&&) noexcept = default;
ScalarRenderer::~ScalarRenderer() = default;
void ScalarRenderer::SetWidth(const vtkm::Int32 width)
void ScalarRenderer::SetWidth(vtkm::Int32 width)
{
if (width < 1)
{
@ -55,12 +55,12 @@ void ScalarRenderer::SetWidth(const vtkm::Int32 width)
Internals->Width = width;
}
void ScalarRenderer::SetDefaultValue(const vtkm::Float32 value)
void ScalarRenderer::SetDefaultValue(vtkm::Float32 value)
{
Internals->DefaultValue = value;
}
void ScalarRenderer::SetHeight(const vtkm::Int32 height)
void ScalarRenderer::SetHeight(vtkm::Int32 height)
{
if (height < 1)
{

11
vtkm/rendering/ScalarRenderer.h
View File

@ -29,20 +29,15 @@ public:
ScalarRenderer(const ScalarRenderer&) = delete;
ScalarRenderer& operator=(const ScalarRenderer&) = delete;
// Note: we are using std::unique_ptr<SomeIncompleteType> with default deleter for PIMPL,
// the compiler does not know how to delete SomeIncompleteType* at this point. Thus, we
// can not omit the declaration of destructor, move assignment operator and let the
// compiler generate implicit default version (which it can't.) We also can not have
// inline definitions of them here. We need to declare them here and have definitions in
// .cxx where SomeIncompleteType becomes complete. The implementations could just be = default.
ScalarRenderer(ScalarRenderer&&) noexcept;
ScalarRenderer& operator=(ScalarRenderer&&) noexcept;
// Default destructor implemented in source file to support PIMPL idiom.
~ScalarRenderer();
void SetInput(vtkm::cont::DataSet& dataSet);
void SetWidth(const vtkm::Int32 width);
void SetHeight(const vtkm::Int32 height);
void SetWidth(vtkm::Int32 width);
void SetHeight(vtkm::Int32 height);
void SetDefaultValue(vtkm::Float32 value);
struct VTKM_RENDERING_EXPORT Result