Shuenhoy/vtk-m
1
0
Fork 0
mirror of https://gitlab.kitware.com/vtk/vtk-m synced 2024-10-08 11:29:02 +00:00
Code Issues 2 Actions Packages Projects Releases Wiki Activity

Do not use volatile when calling CUDA atomicCAS

Browse Source 
Although it makes sense to assume a pointer is `volatile` when doing an
atomic operation, the arguments to the `atomicCAS` overloads take
regular pointers. The overload resolution can fail if you use the
`volatile` keyword.
This commit is contained in:
Kenneth Moreland 2021-03-25 10:11:44 -06:00
parent 6f612107d0
commit d1dba170e8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vtkm/Atomic.h
View File

@ -236,7 +236,7 @@ VTKM_EXEC_CONT inline vtkm::Float32 vtkmAtomicAddImpl(vtkm::Float32* address,
do
{
assumed = old;
old = atomicCAS(reinterpret_cast<volatile vtkm::UInt32*>(address),
old = atomicCAS(reinterpret_cast<vtkm::UInt32*>(address),
assumed,
__float_as_int(__int_as_float(assumed) + value));
} while (assumed != old);
@ -255,7 +255,7 @@ VTKM_EXEC_CONT inline vtkm::Float64 vtkmAtomicAdd(vtkm::Float64* address,
do
{
assumed = old;
old = atomicCAS(reinterpret_cast<volatile vtkm::UInt64*>(address),
old = atomicCAS(reinterpret_cast<vtkm::UInt64*>(address),
assumed,
__double_as_longlong(__longlong_as_double(assumed) + value));
} while (assumed != old);