Shuenhoy/vtk-m2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add change log for removal of TryExecute from filters

Browse Source
This commit is contained in:
Kenneth Moreland 2018-10-17 16:53:15 -06:00
parent bae6e5f4dd
commit 3b847f9aca
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
docs/changelog/filter-no-try-execute.md Normal file
View File

@ -0,0 +1,19 @@
# Remove TryExecute from filter
[A recent change to dispatchers](dispatcher-auto-device.md) has embedded a
`TryExecute` internally within the `Invoke` function of all dispatchers. This
means that it is no longer necessary to specify a device when invoking a
worklet.
Previously, this `TryExecute` was in the filter layer. The filter superclasses
would do a `TryExecute` and use that to pass to subclasses in methods like
`DoExecute` and `DoMapField`. Since the dispatcher no longer needs a device
this `TryExecute` is generally unnecessary and always redundant. Thus, it has
been removed.
Because of this, the device argument to `DoExecute` and `DoMapField` has been
removed. This will cause current implementations of filter to change, but it
usually simplifies code. That said, there might be some code that needs to be
wrapped into a `vtkm::cont::ExecObjectBase`.
No changes need to be made to code that uses filters.