Shuenhoy/vtk-m2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix buffer leak in BufferInfo

Browse Source
This commit is contained in:
Kenneth Moreland 2020-06-26 16:44:40 -06:00
parent 8e1c87b5c2
commit 42219f8d61
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
vtkm/cont/internal/DeviceAdapterMemoryManager.cxx
View File

@ -218,6 +218,15 @@ BufferInfo::BufferInfo(BufferInfo&& src)
BufferInfo& BufferInfo::operator=(const BufferInfo& src)
{
detail::BufferInfoInternals::CountType oldCount =
this->Internals->Count.fetch_sub(1, std::memory_order::memory_order_seq_cst);
if (oldCount == 1)
{
this->Internals->Delete(this->Internals->Container);
delete this->Internals;
this->Internals = nullptr;
}
this->Internals = src.Internals;
this->Device = src.Device;
@ -229,6 +238,15 @@ BufferInfo& BufferInfo::operator=(const BufferInfo& src)
BufferInfo& BufferInfo::operator=(BufferInfo&& src)
{
detail::BufferInfoInternals::CountType oldCount =
this->Internals->Count.fetch_sub(1, std::memory_order::memory_order_seq_cst);
if (oldCount == 1)
{
this->Internals->Delete(this->Internals->Container);
delete this->Internals;
this->Internals = nullptr;
}
this->Internals = src.Internals;
this->Device = src.Device;