Shuenhoy/vtk-m2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge topic 'contour-bug-v1.7' into release-1.7

Browse Source 
a195ce883 Fix Flying Edges z-boundary condition with non-square input

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !2876
This commit is contained in:
Kenneth Moreland 2022-10-13 17:18:15 +00:00 committed by Kitware Robot
commit ca39bd4ea6
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
docs/changelog/flying-edges-z-boundary-fix.md Normal file
View File

@ -0,0 +1,14 @@
# Fixed Flying Edges Crash
There was a bug in VTK-m's flying edges algorithm (in the contour filter
for uniform structured data) that cause the code to read an index from
uninitialized memory. This in turn caused memory reads from an
inappropriate address that could cause bad values, failed assertions, or
segmentation faults.
The problem was caused by a misidentification of edges at the positive z
boundary. Due to a typo, the z index was being compared to the length in
the y dimension. Thus, the problem would only occur in the case where the y
and z dimensions were of different sizes and the contour would go through
the positive z boundary of the data, which was missing our test cases.

2
vtkm/worklet/contour/FlyingEdgesPass4Common.h
View File

@ -185,7 +185,7 @@ struct Pass4TrimState
{
boundaryStatus[AxisToSum::zindex] += FlyingEdges3D::MinBoundary;
}
if (ijk[AxisToSum::zindex] >= (pdims[AxisToSum::yindex] - 2))
if (ijk[AxisToSum::zindex] >= (pdims[AxisToSum::zindex] - 2))
{
boundaryStatus[AxisToSum::zindex] += FlyingEdges3D::MaxBoundary;
}