Shuenhoy/vtk-m2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
f9750e83f7
vtk-m2/vtkm/cont
History
Kenneth Moreland f9750e83f7 Fix issues with Field constructor overloads 
I ran into a few minor issues with the constructors to the Field class.

The big change I made was that I removed the Field constructors that
take an example type and create an empty field of that type. The problem
was that the example type was easily confused with some other type that
was supposed to describe an array. This lead to some odd behavior in the
compiler and resulted in errors in unexpected places.

The use case for this constructor is dubious. There were several tests
in the code that would create an empty field, add it to a data set, then
get it back out to pass to the worklet. The code is much simpler if you
just make an ArrayHandle of the right type and use that in the worklet
invoke directly. It is also faster to compile with smaller code because
the type is known statically (whereas it is lost the other way).

The other change was to declare references to ArrayHandle and
DynamicArrayHandle as const. There is nothing in the behavior that
invalidates the const, and it accepts arrays constructed in the
parameter.
2016-01-21 13:54:05 -07:00
..
arg Add WholeArray* ControlSignature tags 2015-12-07 09:52:29 -07:00
cuda Add ErrorControlCuda for better CUDA error checking. 2016-01-12 15:19:54 -07:00
internal Serial SortByKey works now when the key is a ArrayHandleZip. 2015-12-31 14:45:18 -05:00
tbb FunctorsTBB now uses VTKM_VECTORIZATION_X macros everywhere. 2016-01-12 08:43:06 -05:00
testing Add methods to DataSetFieldAdd that accept a DynamicArrayHandle 2016-01-21 13:00:41 -07:00
ArrayHandle.h Perform less unnecessary copies when deducing a worklets parameters. 2016-01-19 09:20:49 -05:00
ArrayHandleCartesianProduct.h Fix support for CoordinateSystems using ArrayHandleCartesianProduct. 2016-01-07 14:17:23 -05:00
ArrayHandleCast.h Replace ArrayHandleCastForInput with the more versatile ArrayHandleCast. 2015-11-11 17:13:04 -05:00
ArrayHandleCompositeVector.h Support control array portals in composite vector. 2016-01-04 12:53:56 -07:00
ArrayHandleConstant.h Add default constructors/destructors/assignment to ArrayHandle classes 2015-10-21 13:36:27 -06:00
ArrayHandleCounting.h Add default constructors/destructors/assignment to ArrayHandle classes 2015-10-21 13:36:27 -06:00
ArrayHandleGroupVec.h Change Isosurface algorithm to work with scatter counting 2015-11-06 18:05:20 -07:00
ArrayHandleImplicit.h Add default constructors/destructors/assignment to ArrayHandle classes 2015-10-21 13:36:27 -06:00
ArrayHandleIndex.h Add default constructors/destructors/assignment to ArrayHandle classes 2015-10-21 13:36:27 -06:00
ArrayHandlePermutation.h Add default constructors/destructors/assignment to ArrayHandle classes 2015-10-21 13:36:27 -06:00
ArrayHandleTransform.h Add support for bidirectional array transforms. 2015-11-10 15:13:02 -05:00
ArrayHandleUniformPointCoordinates.h Add default constructors/destructors/assignment to ArrayHandle classes 2015-10-21 13:36:27 -06:00
ArrayHandleZip.h Add default constructors/destructors/assignment to ArrayHandle classes 2015-10-21 13:36:27 -06:00
ArrayPortal.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
ArrayPortalToIterators.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
Assert.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
CellSet.h Add GetNumberOfPoints to CellSet. 2015-12-21 17:27:54 -07:00
CellSetExplicit.h Update vtkm tests and examples to use DataSetBuilders. 2016-01-15 15:44:56 -05:00
CellSetListTag.h Add CellSetSingleType 2015-09-25 13:41:41 -04:00
CellSetPermutation.h Add GetNumberOfPoints to CellSet. 2015-12-21 17:27:54 -07:00
CellSetSingleType.h Update vtkm tests and examples to use DataSetBuilders. 2016-01-15 15:44:56 -05:00
CellSetStructured.h Add GetCellDimensions to CellSetStructured. 2016-01-20 09:24:31 -07:00
CMakeLists.txt Change Regular to Uniform 2016-01-19 15:54:05 -07:00
CoordinateSystem.h Fix support for CoordinateSystems using ArrayHandleCartesianProduct. 2016-01-07 14:17:23 -05:00
DataSet.h Cleanup and fix an issue in Explicit dataset testing with the initial merge. 2015-12-04 16:15:51 -05:00
DataSetBuilderExplicit.h Make DataSetBuilder methods static 2016-01-21 10:45:33 -07:00
DataSetBuilderRectilinear.h Make DataSetBuilder methods static 2016-01-21 10:45:33 -07:00
DataSetBuilderUniform.h Make DataSetBuilder methods static 2016-01-21 10:45:33 -07:00
DataSetFieldAdd.h Add methods to DataSetFieldAdd that accept a DynamicArrayHandle 2016-01-21 13:00:41 -07:00
DeviceAdapter.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
DeviceAdapterAlgorithm.h Adding vtkm::cont::RuntimeDeviceInformation. 2015-12-15 17:25:27 -05:00
DeviceAdapterSerial.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
DynamicArrayHandle.h Found a few more places where we don't need to return by value. 2016-01-19 10:54:37 -05:00
DynamicCellSet.h Found a few more places where we don't need to return by value. 2016-01-19 10:54:37 -05:00
Error.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
ErrorControl.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
ErrorControlAssert.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
ErrorControlBadAllocation.h Add Bad Allocation error. 2015-09-22 10:54:22 -04:00
ErrorControlBadType.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
ErrorControlBadValue.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
ErrorControlInternal.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
ErrorExecution.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00
Field.h Fix issues with Field constructor overloads 2016-01-21 13:54:05 -07:00
LogicalStructure.h fleshing out cell set and data set more. 2015-05-11 16:54:16 -04:00
RuntimeDeviceInformation.h Adding vtkm::cont::RuntimeDeviceInformation. 2015-12-15 17:25:27 -05:00
Storage.h Replace ErrorControlOutOfMemory with ErrorControlBadAllocation. 2015-10-01 14:25:28 -04:00
StorageBasic.h Replace ErrorControlOutOfMemory with ErrorControlBadAllocation. 2015-10-01 14:25:28 -04:00
StorageImplicit.h Add additional control logic for CopyInto function 2015-09-17 14:26:19 -04:00
StorageListTag.h Created DynamicCellSet 2015-07-27 16:58:29 -06:00
Timer.h The Copyright statement now has all the periods in the correct location. 2015-05-21 10:30:11 -04:00