THIS IS A TEST INSTANCE ONLY! REPOSITORIES CAN BE DELETED AT ANY TIME!
This website requires JavaScript.
Explore
Help
Sign In
TEST_CODEOWNERS
/
rails
Watch
3
Star
0
Fork
0
You've already forked rails
Code
Issues
Pull Requests
1
Actions
Packages
Projects
Releases
Wiki
Activity
dd1761e6bb
rails
/
activerecord
/
test
/
models
/
recipe.rb
6 lines
88 B
Ruby
Raw
Normal View
History
Unescape
Escape
Use frozen-string-literal in ActiveRecord
2017-07-09 17:41:28 +00:00
# frozen_string_literal: true
Fix leaky chain on polymorphic association If there was a polymorphic hm:t association with a scope AND second non-scoped hm:t association on a model the polymorphic scope would leak through into the call for the non-polymorhic hm:t association. This would only break if `hotel.drink_designers` was called before `hotel.recipes`. If `hotel.recipes` was called first there would be no problem with the SQL. Before (employable_type should not be here): ``` SELECT COUNT(*) FROM "drink_designers" INNER JOIN "chefs" ON "drink_designers"."id" = "chefs"."employable_id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? AND "chefs"."employable_type" = ? [["hotel_id", 1], ["employable_type", "DrinkDesigner"]] ``` After: ``` SELECT COUNT(*) FROM "recipes" INNER JOIN "chefs" ON "recipes"."chef_id" = "chefs"."id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? [["hotel_id", 1]] ``` From the SQL you can see that `employable_type` was leaking through when calling recipes. The solution is to dup the chain of the polymorphic association so it doesn't get cached. Additionally, this follows `scope_chain` which dup's the `source_reflection`'s `scope_chain`. This required another model/table/relationship because the leak only happens on a hm:t polymorphic that's called before another hm:t on the same model. I am specifically testing the SQL here instead of the number of records becasue the test could pass if there was 1 drink designer recipe for the drink designer chef even though the `employable_type` was leaking through. This needs to specifically check that `employable_type` is not in the SQL statement.
2015-03-15 14:33:29 +00:00
class
Recipe
<
ActiveRecord
::
Base
belongs_to
:chef
end
Reference in New Issue
Copy Permalink