TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Remove deprecated rake dev:cache tasks

Browse Source
This commit is contained in:
Rafael Mendonça França 2020-10-29 21:17:17 +00:00
parent c0728ad321
commit 01f0020a55
No known key found for this signature in database
GPG Key ID: FC23B6D0F1EEE948
5 changed files with 6 additions and 75 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
guides/source/6_1_release_notes.md
View File

@ -43,6 +43,8 @@ Please refer to the [Changelog][railties] for detailed changes.
* Remove deprecated support for using the `HOST` environment variable to specify the server IP.
* Remove deprecated `rake dev:cache` tasks.
### Deprecations
### Notable changes

4
railties/CHANGELOG.md
View File

@ -1,3 +1,7 @@
* Remove deprecated `rake dev:cache` tasks.
*Rafael Mendonça França*
* Remove deprecated support for using the `HOST` environment variable to specify the server IP.
*Rafael Mendonça França*

1
railties/lib/rails/tasks.rb
View File

@ -4,7 +4,6 @@
# Load Rails Rakefile extensions
%w(
dev
framework
initializers
log

11
railties/lib/rails/tasks/dev.rake
View File

@ -1,11 +0,0 @@
# frozen_string_literal: true
require "rails/command"
require "active_support/deprecation"
namespace :dev do
task cache: :environment do
ActiveSupport::Deprecation.warn("Using `bin/rake dev:cache` is deprecated and will be removed in Rails 6.1. Use `bin/rails dev:cache` instead.\n")
Rails::Command.invoke "dev:cache"
end
end

63
railties/test/application/rake/dev_test.rb
View File

@ -1,63 +0,0 @@
# frozen_string_literal: true
require "isolation/abstract_unit"
module ApplicationTests
module RakeTests
class RakeDevTest < ActiveSupport::TestCase
include ActiveSupport::Testing::Isolation
def setup
build_app
add_to_env_config("development", "config.active_support.deprecation = :stderr")
end
def teardown
teardown_app
end
test "dev:cache creates file and outputs message" do
Dir.chdir(app_path) do
stderr = capture(:stderr) do
output = run_rake_dev_cache
assert File.exist?("tmp/caching-dev.txt")
assert_match(/Development mode is now being cached/, output)
end
assert_match(/DEPRECATION WARNING: Using `bin\/rake dev:cache` is deprecated and will be removed in Rails 6.1/, stderr)
end
end
test "dev:cache deletes file and outputs message" do
Dir.chdir(app_path) do
stderr = capture(:stderr) do
run_rake_dev_cache # Create caching file.
output = run_rake_dev_cache # Delete caching file.
assert_not File.exist?("tmp/caching-dev.txt")
assert_match(/Development mode is no longer being cached/, output)
end
assert_match(/DEPRECATION WARNING: Using `bin\/rake dev:cache` is deprecated and will be removed in Rails 6.1/, stderr)
end
end
test "dev:cache touches tmp/restart.txt" do
Dir.chdir(app_path) do
stderr = capture(:stderr) do
run_rake_dev_cache
assert File.exist?("tmp/restart.txt")
prev_mtime = File.mtime("tmp/restart.txt")
run_rake_dev_cache
curr_mtime = File.mtime("tmp/restart.txt")
assert_not_equal prev_mtime, curr_mtime
end
assert_match(/DEPRECATION WARNING: Using `bin\/rake dev:cache` is deprecated and will be removed in Rails 6.1/, stderr)
end
end
private
def run_rake_dev_cache
`bin/rake dev:cache`
end
end
end
end