TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Remove deprecated methods in ActionDispatch::TestResponse

Browse Source 
`#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
`#successful?`, `not_found?` and `server_error?`.
This commit is contained in:
Rafael Mendonça França 2019-01-14 15:03:29 -05:00
parent 12f55cefde
commit 13ddc92e07
No known key found for this signature in database
GPG Key ID: FC23B6D0F1EEE948
3 changed files with 7 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
actionpack/CHANGELOG.md
View File

@ -1,3 +1,10 @@
* Remove deprecated methods in `ActionDispatch::TestResponse`.
`#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
`#successful?`, `not_found?` and `server_error?`.
*Rafael Mendonça França*
* Ensure external redirects are explicitly allowed
Add `fallback_location` and `allow_other_host` options to `redirect_to`.

27
actionpack/lib/action_dispatch/testing/test_response.rb
View File

@ -14,33 +14,6 @@ def self.from_response(response)
new response.status, response.headers, response.body
end
# Was the response successful?
def success?
ActiveSupport::Deprecation.warn(<<-MSG.squish)
The success? predicate is deprecated and will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
MSG
successful?
end
# Was the URL not found?
def missing?
ActiveSupport::Deprecation.warn(<<-MSG.squish)
The missing? predicate is deprecated and will be removed in Rails 6.0.
Please use not_found? as provided by Rack::Response::Helpers.
MSG
not_found?
end
# Was there a server-side error?
def error?
ActiveSupport::Deprecation.warn(<<-MSG.squish)
The error? predicate is deprecated and will be removed in Rails 6.0.
Please use server_error? as provided by Rack::Response::Helpers.
MSG
server_error?
end
def parsed_body
@parsed_body ||= response_parser.call(body)
end

7
actionpack/test/dispatch/test_response_test.rb
View File

@ -27,11 +27,4 @@ def assert_response_code_range(range, predicate)
response = ActionDispatch::TestResponse.create(200, { "Content-Type" => "application/json" }, '{ "foo": "fighters" }')
assert_equal({ "foo" => "fighters" }, response.parsed_body)
end
test "response status aliases deprecated" do
response = ActionDispatch::TestResponse.create
assert_deprecated { response.success? }
assert_deprecated { response.missing? }
assert_deprecated { response.error? }
end
end