TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Revert "remove unnecssary require of to_param, as to_query is already require to_param"

Browse Source 
Revert "No need to require to_param, it is already required in to_query.rb"

This reverts commits ccdd97662e1fb00c23c90d59f65c091904959561
and d697ee14264a90a39cdbe87857656d8b314ac9b7.

Reason by @jeremy: These requires are not for implementation dependency.
They ensure that requiring array conversions provides to_query, to_param,
and other array conversion behaviors.

The fact that to_query is implemented in terms of to_param is just a
coincidence. If to_query removed its to_param require, then someone
requiring array conversions would no longer have to_param available.

This change removes these intentional dependencies on to_param in favor
of implementation side effects—an undesirable move that's susceptible to
regression.
This commit is contained in:
Rafael Mendonça França 2014-06-11 17:10:26 -03:00
parent 168dc1968c
commit 15c2a5be6e
4 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
activesupport/lib/active_support/core_ext/array/conversions.rb
View File

@ -1,6 +1,7 @@
require 'active_support/xml_mini'
require 'active_support/core_ext/hash/keys'
require 'active_support/core_ext/string/inflections'
require 'active_support/core_ext/object/to_param'
require 'active_support/core_ext/object/to_query'
class Array

1
activesupport/lib/active_support/core_ext/hash/conversions.rb
View File

@ -1,6 +1,7 @@
require 'active_support/xml_mini'
require 'active_support/time'
require 'active_support/core_ext/object/blank'
require 'active_support/core_ext/object/to_param'
require 'active_support/core_ext/object/to_query'
require 'active_support/core_ext/array/wrap'
require 'active_support/core_ext/hash/reverse_merge'

1
activesupport/lib/active_support/core_ext/object.rb
View File

@ -9,5 +9,6 @@
require 'active_support/core_ext/object/instance_variables'
require 'active_support/core_ext/object/json'
require 'active_support/core_ext/object/to_param'
require 'active_support/core_ext/object/to_query'
require 'active_support/core_ext/object/with_options'

1
activesupport/lib/active_support/core_ext/object/conversions.rb
View File

@ -1,3 +1,4 @@
require 'active_support/core_ext/object/to_param'
require 'active_support/core_ext/object/to_query'
require 'active_support/core_ext/array/conversions'
require 'active_support/core_ext/hash/conversions'