Merge pull request #12842 from kuldeepaggarwal/array_split

Speed up Array#split when block is passed
2013-11-11 00:02:50 -08:00 · 2013-11-11 00:02:50 -08:00 · 15ef6bed18
commit 15ef6bed18
parent d17e79b0f3 4aadd160ff
1 changed files with 3 additions and 3 deletions
--- a/activesupport/lib/active_support/core_ext/array/grouping.rb
+++ b/activesupport/lib/active_support/core_ext/array/grouping.rb
@ -83,10 +83,10 @@ def in_groups(number, fill_with = nil)
  #
  #   [1, 2, 3, 4, 5].split(3)              # => [[1, 2], [4, 5]]
  #   (1..10).to_a.split { |i| i % 3 == 0 } # => [[1, 2], [4, 5], [7, 8], [10]]
-  def split(value = nil, &block)
-    if block
+  def split(value = nil)
+    if block_given?
      inject([[]]) do |results, element|
-        if block.call(element)
+        if yield(element)
          results << []
        else
          results.last << element