TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

button_tag should escape it content

Browse Source
This commit is contained in:
Santiago Pastorino 2011-01-12 22:05:52 -02:00
parent 20897a6c2c
commit 1de47a0d56
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actionpack/lib/action_view/helpers/form_tag_helper.rb
View File

@ -457,7 +457,7 @@ def button_tag(label = "Button", options = {})
options[option] = "button" unless options[option]
end
content_tag :button, label.to_s.html_safe, { "type" => options.delete("type") }.update(options)
content_tag :button, label, { "type" => options.delete("type") }.update(options)
end
# Displays an image which when clicked will submit the form.

7
actionpack/test/template/form_tag_helper_test.rb
View File

@ -413,6 +413,13 @@ def test_button_tag_with_disabled_option
)
end
def test_button_tag_escape_content
assert_dom_equal(
%(<button name="button" type="reset" disabled="disabled">&lt;b&gt;Reset&lt;/b&gt;</button>),
button_tag("<b>Reset</b>", :type => "reset", :disabled => true)
)
end
def test_image_submit_tag_with_confirmation
assert_dom_equal(
%(<input type="image" src="/images/save.gif" data-confirm="Are you sure?" />),