exclude ORDER BY clause for exists? (#28699)
This commit is contained in:
parent
ee0f5c3f59
commit
24ac36be71
@ -383,7 +383,7 @@ def find_with_associations
|
|||||||
end
|
end
|
||||||
|
|
||||||
def construct_relation_for_exists(relation, conditions)
|
def construct_relation_for_exists(relation, conditions)
|
||||||
relation = relation.except(:select, :distinct)._select!(ONE_AS_ONE).limit!(1)
|
relation = relation.except(:select, :distinct, :order)._select!(ONE_AS_ONE).limit!(1)
|
||||||
|
|
||||||
case conditions
|
case conditions
|
||||||
when Array, Hash
|
when Array, Hash
|
||||||
|
@ -208,6 +208,11 @@ def test_exists_with_order_and_distinct
|
|||||||
assert_equal true, Topic.order(:id).distinct.exists?
|
assert_equal true, Topic.order(:id).distinct.exists?
|
||||||
end
|
end
|
||||||
|
|
||||||
|
# Ensure +exists?+ runs without an error by excluding order value.
|
||||||
|
def test_exists_with_order
|
||||||
|
assert_equal true, Topic.order("invalid sql here").exists?
|
||||||
|
end
|
||||||
|
|
||||||
def test_exists_with_joins
|
def test_exists_with_joins
|
||||||
assert_equal true, Topic.joins(:replies).where(replies_topics: { approved: true }).order("replies_topics.created_at DESC").exists?
|
assert_equal true, Topic.joins(:replies).where(replies_topics: { approved: true }).order("replies_topics.created_at DESC").exists?
|
||||||
end
|
end
|
||||||
|
Loading…
Reference in New Issue
Block a user