TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Delete AS::Dependencies.new_constants_in

Browse Source
This commit is contained in:
Xavier Noria 2021-08-18 22:53:43 +02:00
parent e24ae73021
commit 2b31655493
2 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
activesupport/lib/active_support/dependencies.rb
View File

@ -262,31 +262,6 @@ def mark_for_unload(const_desc)
end end
end end
# Run the provided block and detect the new constants that were loaded during
# its execution. Constants may only be regarded as 'new' once -- so if the
# block calls +new_constants_in+ again, then the constants defined within the
# inner call will not be reported in this one.
#
# If the provided block does not run to completion, and instead raises an
# exception, any new constants are regarded as being only partially defined
# and will be removed immediately.
def new_constants_in(*descs)
constant_watch_stack.watch_namespaces(descs)
success = false
begin
yield # Now yield to the code that is to define new constants.
success = true
ensure
new_constants = constant_watch_stack.new_constants
return new_constants if success
# Remove partially loaded constants.
new_constants.each { |c| remove_constant(c) }
end
end
# Convert the provided const desc to a qualified constant name (as a string). # Convert the provided const desc to a qualified constant name (as a string).
# A module, class, symbol, or string may be provided. # A module, class, symbol, or string may be provided.
def to_constant_name(desc) # :nodoc: def to_constant_name(desc) # :nodoc:

13
activesupport/test/dependencies_test.rb
View File

@ -53,19 +53,6 @@ def test_qualified_const_defined_should_not_call_const_missing
def test_qualified_const_defined_explodes_with_invalid_const_name def test_qualified_const_defined_explodes_with_invalid_const_name
assert_raises(NameError) { ActiveSupport::Dependencies.qualified_const_defined?("invalid") } assert_raises(NameError) { ActiveSupport::Dependencies.qualified_const_defined?("invalid") }
end end
def test_new_constants_in_with_inherited_constants
m = ActiveSupport::Dependencies.new_constants_in(:Object) do
Object.class_eval { include ModuleWithConstant }
end
assert_equal [], m
end
def test_new_constants_in_with_illegal_module_name_raises_correct_error
assert_raise(NameError) do
ActiveSupport::Dependencies.new_constants_in("Illegal-Name") { }
end
end
end end
class RequireDependencyTest < ActiveSupport::TestCase class RequireDependencyTest < ActiveSupport::TestCase