TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

bundle binstubs bundler should be executed after bundle install

Browse Source 
Fixes:

`bundle binstubs bundler` doesn't generate `bin/bundle` for newly
generated Rails app.

```
...
(snip)
run  bundle binstubs bundler
The git source https://github.com/rails/web-console.git is not yet checked out.
Please run `bundle install` before trying to start your application
run  bundle install
Fetching https://github.com/rails/web-console.git
(snip)
...
```

Related to #33202
This commit is contained in:
bogdanvlviv 2018-08-11 18:51:10 +03:00
parent 09e1452eeb
commit 2c667814c8
No known key found for this signature in database
GPG Key ID: E4ACD76A6DB6DFDD
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
railties/lib/rails/generators/rails/app/app_generator.rb
View File

@ -298,8 +298,6 @@ def create_bin_files
build(:bin)
end
public_task :generate_bundler_binstub
def update_bin_files
build(:bin_when_updating)
end
@ -471,7 +469,8 @@ def finish_template
end
public_task :apply_rails_template, :run_bundle
public_task :run_webpack, :generate_spring_binstubs
public_task :generate_bundler_binstub, :generate_spring_binstubs
public_task :run_webpack
def run_after_bundle_callbacks
@after_bundle_callbacks.each(&:call)

2
railties/test/generators/app_generator_test.rb
View File

@ -972,7 +972,7 @@ def test_after_bundle_callback
template
end
sequence = ["git init", "binstubs bundler", "install", "exec spring binstub --all", "echo ran after_bundle"]
sequence = ["git init", "install", "binstubs bundler", "exec spring binstub --all", "echo ran after_bundle"]
@sequence_step ||= 0
ensure_bundler_first = -> command, options = nil do
assert_equal sequence[@sequence_step], command, "commands should be called in sequence #{sequence}"