Delete MiniMagick tempfile when transformation fails

2017-12-18 22:01:48 -05:00 · 2017-12-18 22:01:48 -05:00 · 2df99f8bc5
commit 2df99f8bc5
parent d9e4bffb60
1 changed files with 7 additions and 1 deletions
--- a/activestorage/app/models/active_storage/variant.rb
+++ b/activestorage/app/models/active_storage/variant.rb
@ -104,7 +104,13 @@ def content_type


    def open_image(&block)
-      download_image.tap(&block).destroy!
+      image = download_image
+
+      begin
+        yield image
+      ensure
+        image.destroy!
+      end
    end

    def download_image