Moving the common code of increment and decrement of cache file store into seprate function
Removing the double checking for the value of id simplifying code for checking conditional code for key Removing the default values for parameters removing reduntant code and asiigning value of id in local variable removing wrongly added line break[ci ckip] reverting code
This commit is contained in:
parent
11c0ef58a6
commit
337a07b589
@ -43,33 +43,13 @@ def cleanup(options = nil)
|
||||
# Increments an already existing integer value that is stored in the cache.
|
||||
# If the key is not found nothing is done.
|
||||
def increment(name, amount = 1, options = nil)
|
||||
file_name = key_file_path(namespaced_key(name, options))
|
||||
lock_file(file_name) do
|
||||
options = merged_options(options)
|
||||
if num = read(name, options)
|
||||
num = num.to_i + amount
|
||||
write(name, num, options)
|
||||
num
|
||||
else
|
||||
nil
|
||||
end
|
||||
end
|
||||
modify_value(name, amount, options)
|
||||
end
|
||||
|
||||
# Decrements an already existing integer value that is stored in the cache.
|
||||
# If the key is not found nothing is done.
|
||||
def decrement(name, amount = 1, options = nil)
|
||||
file_name = key_file_path(namespaced_key(name, options))
|
||||
lock_file(file_name) do
|
||||
options = merged_options(options)
|
||||
if num = read(name, options)
|
||||
num = num.to_i - amount
|
||||
write(name, num, options)
|
||||
num
|
||||
else
|
||||
nil
|
||||
end
|
||||
end
|
||||
modify_value(name, amount*-1, options)
|
||||
end
|
||||
|
||||
def delete_matched(matcher, options = nil)
|
||||
@ -184,6 +164,20 @@ def search_dir(dir, &callback)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
#This method performs an action(passed) already existing integer value that is stored in the cache
|
||||
# If the key is not found nothing is done
|
||||
def modify_value(name, amount, options)
|
||||
file_name = key_file_path(namespaced_key(name, options))
|
||||
lock_file(file_name) do
|
||||
options = merged_options(options)
|
||||
if num = read(name, options)
|
||||
num = num.to_i + amount
|
||||
write(name, num, options)
|
||||
num
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
Loading…
Reference in New Issue
Block a user