TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #4353 from dmathieu/hide_nil_unchecked_checkbox

Browse Source 
don't set the hidden checkbox value if it's nil
This commit is contained in:
José Valim 2012-01-06 09:12:11 -08:00
commit 365a34c92f
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actionpack/lib/action_view/helpers/form_helper.rb
View File

@ -1091,7 +1091,7 @@ def to_check_box_tag(options = {}, checked_value = "1", unchecked_value = "0")
else
add_default_name_and_id(options)
end
hidden = tag("input", "name" => options["name"], "type" => "hidden", "value" => unchecked_value, "disabled" => options["disabled"])
hidden = unchecked_value ? tag("input", "name" => options["name"], "type" => "hidden", "value" => unchecked_value, "disabled" => options["disabled"]) : ""
checkbox = tag("input", options)
hidden + checkbox
end

8
actionpack/test/template/form_helper_test.rb
View File

@ -374,6 +374,14 @@ def test_check_box_with_explicit_checked_and_unchecked_values
)
end
def test_check_box_with_nil_unchecked_value
@post.secret = "on"
assert_dom_equal(
'<input checked="checked" id="post_secret" name="post[secret]" type="checkbox" value="on" />',
check_box("post", "secret", {}, "on", nil)
)
end
def test_check_box_with_multiple_behavior
@post.comment_ids = [2,3]
assert_dom_equal(