Fix previous commit by allowing a proc to be given as response_body. This is deprecated and is going to be removed in future releases.

actionpack/lib/action_dispatch/http/cache.rb

@@ -42,20 +42,6 @@ module Response
         attr_reader :cache_control, :etag
         alias :etag? :etag
 
-        def initialize(*)
-          super
-
-          @cache_control = {}
-          @etag = self["ETag"]
-
-          if cache_control = self["Cache-Control"]
-            cache_control.split(/,\s*/).each do |segment|
-              first, last = segment.split("=")
-              @cache_control[first.to_sym] = last || true
-            end
-          end
-        end
-
         def last_modified
           if last = headers['Last-Modified']
             Time.httpdate(last)
@@ -77,6 +63,18 @@ def etag=(etag)
 
       private
 
+        def prepare_cache_control!
+          @cache_control = {}
+          @etag = self["ETag"]
+
+          if cache_control = self["Cache-Control"]
+            cache_control.split(/,\s*/).each do |segment|
+              first, last = segment.split("=")
+              @cache_control[first.to_sym] = last || true
+            end
+          end
+        end
+
         def handle_conditional_get!
           if etag? || last_modified? || !@cache_control.empty?
             set_conditional_cache_control!

actionpack/lib/action_dispatch/http/response.rb

@@ -56,27 +56,26 @@ class Response
 
     cattr_accessor(:default_charset) { "utf-8" }
 
-    module Setup
-      def initialize(status = 200, header = {}, body = [])
-        self.body, self.header, self.status = body, header, status
-
-        @sending_file = false
-        @blank = false
-
-        if content_type = self["Content-Type"]
-          type, charset = content_type.split(/;\s*charset=/)
-          @content_type = Mime::Type.lookup(type)
-          @charset = charset || "UTF-8"
-        end
-
-        yield self if block_given?
-      end
-    end
-
     include Rack::Response::Helpers
-    include Setup
     include ActionDispatch::Http::Cache::Response
 
+    def initialize(status = 200, header = {}, body = [])
+      self.body, self.header, self.status = body, header, status
+
+      @sending_file = false
+      @blank = false
+
+      if content_type = self["Content-Type"]
+        type, charset = content_type.split(/;\s*charset=/)
+        @content_type = Mime::Type.lookup(type)
+        @charset = charset || "UTF-8"
+      end
+
+      prepare_cache_control!
+
+      yield self if block_given?
+    end
+
     def status=(status)
       @status = Rack::Utils.status_code(status)
     end
@@ -116,9 +115,32 @@ def body
 
     EMPTY = " "
 
+    class BodyBuster #:nodoc:
+      def initialize(response)
+        @response = response
+        @body = ""
+      end
+
+      def bust(body)
+        body.call(@response, self)
+        body.close if body.respond_to?(:close)
+        @body
+      end
+
+      def write(string)
+        @body << string.to_s
+      end
+    end
+
     def body=(body)
       @blank = true if body == EMPTY
 
+      if body.respond_to?(:call)
+        ActiveSupport::Deprecation.warn "Setting a Proc or an object that responds to call " \
+          "in response_body is no longer supported", caller
+        body = BodyBuster.new(self).bust(body)
+      end
+
       # Explicitly check for strings. This is *wrong* theoretically
       # but if we don't check this, the performance on string bodies
       # is bad on Ruby 1.8 (because strings responds to each then).
@@ -150,6 +172,10 @@ def location=(url)
       headers['Location'] = url
     end
 
+    def close
+      @body.close if @body.respond_to?(:close)
+    end
+
     def to_a
       assign_default_content_type_and_charset!
       handle_conditional_get!

actionpack/test/dispatch/response_body_is_proc_test.rb

@@ -3,25 +3,24 @@
 class ResponseBodyIsProcTest < ActionDispatch::IntegrationTest
   class TestController < ActionController::Base
     def test
-      request.session_options[:renew] = true
       self.response_body = proc { |response, output|
-        puts caller
         output.write 'Hello'
       }
     end
-
-    def rescue_action(e) raise end
   end
 
   def test_simple_get
     with_test_route_set do
-      get '/test'
+      assert_deprecated do
+        get '/test'
+      end
       assert_response :success
       assert_equal 'Hello', response.body
     end
   end
 
   private
+
     def with_test_route_set(options = {})
       with_routing do |set|
         set.draw do