TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Catch Time.zone before TestHelper resets it to UTC

Browse Source 
This is most easiest done by switching to before_setup, which fits since
we're also testing the ordering of the reset calls provided by the
TestHelper.
This commit is contained in:
Kasper Timm Hansen 2020-06-02 01:29:40 +02:00
parent a9c27de2c2
commit 3b953da779
No known key found for this signature in database
GPG Key ID: 191153215EDA53D8
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
activesupport/test/current_attributes_test.rb
View File

@ -47,8 +47,17 @@ class Session < ActiveSupport::CurrentAttributes
# Eagerly set-up `instance`s by reference. # Eagerly set-up `instance`s by reference.
[ Current.instance, Session.instance ] [ Current.instance, Session.instance ]
setup { @original_time_zone = Time.zone } # Use library specific minitest hook to catch Time.zone before reset is called via TestHelper
teardown { Time.zone = @original_time_zone } def before_setup
@original_time_zone = Time.zone
super
end
# Use library specific minitest hook to set Time.zone after reset is called via TestHelper
def after_teardown
super
Time.zone = @original_time_zone
end
setup { assert_nil Session.previous, "Expected Session to not have leaked state" } setup { assert_nil Session.previous, "Expected Session to not have leaked state" }