Simplify (and optimize)

2012-11-16 03:35:42 -05:00 · 2012-11-16 03:35:42 -05:00 · 3c4a0b2e68
commit 3c4a0b2e68
parent 22edb664cf
1 changed files with 3 additions and 3 deletions
--- a/activesupport/lib/active_support/core_ext/array/grouping.rb
+++ b/activesupport/lib/active_support/core_ext/array/grouping.rb
@ -67,9 +67,9 @@ def in_groups(number, fill_with = nil)

    number.times do |index|
      length = division + (modulo > 0 && modulo > index ? 1 : 0)
-      padding = fill_with != false &&
-        modulo > 0 && length == division ? 1 : 0
-      groups << slice(start, length).concat([fill_with] * padding)
+      groups << last_group = slice(start, length)
+      last_group << fill_with if fill_with != false &&
+        modulo > 0 && length == division
      start += length
    end