TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #47200 from skipkayhil/use-ad-deprecator-illegal-state

Browse Source 
Use AD.deprecator for IllegalStateError
This commit is contained in:
Eileen M. Uchitelle 2023-01-31 08:48:59 -05:00 committed by GitHub
commit 3cca0d5205
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
actionpack/lib/action_dispatch.rb
View File

@ -36,11 +36,14 @@ module Rack
end
module ActionDispatch
include ActiveSupport::Deprecation::DeprecatedConstantAccessor
extend ActiveSupport::Autoload
class IllegalStateError < StandardError
class DeprecatedIllegalStateError < StandardError
end
deprecate_constant :IllegalStateError
deprecate_constant "IllegalStateError", "ActionDispatch::DeprecatedIllegalStateError",
message: "ActionDispatch::IllegalStateError is deprecated without replacement.",
deprecator: ActionDispatch.deprecator
class MissingController < NameError
end

6
actionpack/test/dispatch/response_test.rb
View File

@ -10,6 +10,12 @@ def setup
@response.request = ActionDispatch::Request.empty
end
def test_illegal_state_error_is_deprecated
assert_deprecated(ActionDispatch.deprecator) do
ActionDispatch::IllegalStateError
end
end
def test_can_wait_until_commit
t = Thread.new {
@response.await_commit