Don't add CHANGELOG offenses to "no changes" line

This commit is contained in:
Rafael Mendonça França 2023-09-27 03:17:26 +00:00
parent e5386cb402
commit 4bd5d20a92
No known key found for this signature in database
GPG Key ID: FC23B6D0F1EEE948
3 changed files with 58 additions and 0 deletions

@ -36,6 +36,8 @@ def header
end
def validate_authors
return if no_changes?
authors =
lines.reverse.find { |line| line.match?(/\*[^\d\s]+(\s[^\d\s]+)*\*/) }
@ -87,6 +89,10 @@ def validate_trailing_whitespace
end
private
def no_changes?
lines.first == "* No changes."
end
def add_offense(...)
@offenses << Offense.new(...)
end

@ -0,0 +1,46 @@
## Rails 7.1.0.rc1 (September 13, 2023) ##
* No changes.
## Rails 7.1.0.beta1 (September 13, 2023) ##
* Fix `simple_format` with blank `wrapper_tag` option returns plain html tag
By default `simple_format` method returns the text wrapped with `<p>`. But if we explicitly specify
the `wrapper_tag: nil` in the options, it returns the text wrapped with `<></>` tag.
Before:
```ruby
simple_format("Hello World", {}, { wrapper_tag: nil })
# <>Hello World</>
```
After:
```ruby
simple_format("Hello World", {}, { wrapper_tag: nil })
# <p>Hello World</p>
```
*Akhil G Krishnan*, *Junichi Ito*
* Don't double-encode nested `field_id` and `field_name` index values
Pass `index: @options` as a default keyword argument to `field_id` and
`field_name` view helper methods.
*Sean Doyle*
* Allow opting in/out of `Link preload` headers when calling `stylesheet_link_tag` or `javascript_include_tag`
```ruby
# will exclude header, even if setting is enabled:
javascript_include_tag("http://example.com/all.js", preload_links_header: false)
# will include header, even if setting is disabled:
stylesheet_link_tag("http://example.com/all.js", preload_links_header: true)
```
*Alex Ghiculescu*

@ -54,6 +54,12 @@ def test_release_header_is_not_treated_as_offense
assert_equal 0, offenses.length
end
def test_no_changes_not_treated_as_offense
@changelog = changelog_fixture("action_mailbox.md")
assert_equal 0, offenses.length
end
def test_validate_authors
assert_offense(<<~CHANGELOG)
* Fix issue in CHANGELOG linting