Merge pull request #34682 from gmcgibbon/rm_system_test_generator_suffix
Remove redundant suffixes on generated system tests.
This commit is contained in:
commit
4dd06452ef
@ -1,3 +1,7 @@
|
|||||||
|
* Remove redundant suffixes on generated system tests.
|
||||||
|
|
||||||
|
*Gannon McGibbon*
|
||||||
|
|
||||||
* Add an `abort_on_failure` boolean option to the generator method that shell
|
* Add an `abort_on_failure` boolean option to the generator method that shell
|
||||||
out (`generate`, `rake`, `rails_command`) to abort the generator if the
|
out (`generate`, `rake`, `rails_command`) to abort the generator if the
|
||||||
command fails.
|
command fails.
|
||||||
|
@ -14,6 +14,11 @@ def create_test_files
|
|||||||
|
|
||||||
template "system_test.rb", File.join("test/system", class_path, "#{file_name.pluralize}_test.rb")
|
template "system_test.rb", File.join("test/system", class_path, "#{file_name.pluralize}_test.rb")
|
||||||
end
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
def file_name
|
||||||
|
@_file_name ||= super.sub(/_test\z/i, "")
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -16,4 +16,18 @@ def test_namespaced_system_test_skeleton_is_created
|
|||||||
run_generator %w(admin/user)
|
run_generator %w(admin/user)
|
||||||
assert_file "test/system/admin/users_test.rb", /class Admin::UsersTest < ApplicationSystemTestCase/
|
assert_file "test/system/admin/users_test.rb", /class Admin::UsersTest < ApplicationSystemTestCase/
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def test_test_name_is_pluralized
|
||||||
|
run_generator %w(user)
|
||||||
|
|
||||||
|
assert_no_file "test/system/user_test.rb"
|
||||||
|
assert_file "test/system/users_test.rb"
|
||||||
|
end
|
||||||
|
|
||||||
|
def test_test_suffix_is_not_duplicated
|
||||||
|
run_generator %w(users_test)
|
||||||
|
|
||||||
|
assert_no_file "test/system/users_test_test.rb"
|
||||||
|
assert_file "test/system/users_test.rb"
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
Loading…
Reference in New Issue
Block a user