Pull generated methods up in to the anonymous subclass

Then we don't need the extra module.
This commit is contained in:
Aaron Patterson 2019-01-24 12:43:07 -08:00
parent 6dcd43b2a8
commit 517b96207d
No known key found for this signature in database
GPG Key ID: 953170BCB4FFAFC6
3 changed files with 8 additions and 19 deletions

@ -9,11 +9,6 @@ module ActionDispatch
class DebugView < ActionView::Base # :nodoc:
RESCUES_TEMPLATE_PATH = File.expand_path("templates", __dir__)
module CompiledTemplates
end
include CompiledTemplates
def initialize(assigns)
paths = [RESCUES_TEMPLATE_PATH]
renderer = ActionView::Renderer.new ActionView::LookupContext.new(paths)
@ -21,7 +16,7 @@ def initialize(assigns)
end
def compiled_method_container
CompiledTemplates
self.class
end
def debug_params(params)

@ -182,11 +182,12 @@ def xss_safe? #:nodoc:
end
def with_empty_template_cache # :nodoc:
template_container = Module.new
Class.new(self) {
include template_container
define_method(:compiled_method_container) { template_container }
define_singleton_method(:compiled_method_container) { template_container }
subclass = Class.new(self) {
# We can't implement these as self.class because subclasses will
# share the same template cache as superclasses, so "changed?" won't work
# correctly.
define_method(:compiled_method_container) { subclass }
define_singleton_method(:compiled_method_container) { subclass }
}
end

@ -19,15 +19,8 @@ def combined_fragment_cache_key(key)
end.with_view_paths(paths, @assigns)
controller = TestController.new
view = @view
@controller_view = Class.new(controller.view_context_class) do
include view.compiled_method_container
define_method(:compiled_method_container) do
view.compiled_method_container
end
end.new(controller.view_renderer, controller.view_assigns, controller)
@controller_view = controller.view_context_class.with_empty_template_cache.new(controller.view_renderer, controller.view_assigns, controller)
# Reload and register danish language for testing
I18n.backend.store_translations "da", {}