TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix contributing guide to reflect preferred position on indentation

Browse Source 
Fix incorrect recommendation from indenting after private/protected to not.

Based on opinions of @spastorino, @jonleighton, @tenderlove

https://github.com/rails/rails/pull/1838#issuecomment-1440281
https://en.twitter.com/#!/spastorino/status/142054749351575552
https://en.twitter.com/#!/tenderlove/status/142014046445641728
https://en.twitter.com/#!/jonleighton/status/142021813415841794
This commit is contained in:
brainopia 2012-01-26 10:04:57 +04:00
parent 522c0fdb55
commit 51ccb7f59c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
railties/guides/source/contributing_to_ruby_on_rails.textile
View File

@ -309,7 +309,7 @@ Rails follows a simple set of coding style conventions.
* Two spaces, no tabs.
* No trailing whitespace. Blank lines should not have any space.
* Indent after private/protected.
* Do not indent after private/protected. Private/protected should have the same indentation as the methods around.
* Prefer +&&+/+||+ over +and+/+or+.
* Prefer class << self block over self.method for class methods.
* +MyClass.my_method(my_arg)+ not +my_method( my_arg )+ or +my_method my_arg+.