Merge pull request #51791 from duduribeiro/add-name-to-devcontainer-compose

Add name to DevContainer compose file
This commit is contained in:
Rafael Mendonça França 2024-05-13 14:10:47 -04:00 committed by GitHub
commit 5c933a3d82
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 0 deletions

@ -33,6 +33,10 @@ jobs:
- name: Generate rails app sqlite3
run: bundle exec railties/exe/rails new myapp_sqlite --database="sqlite3" --dev
- name: Remove old deprecated docker-compose
run: |
sudo rm /usr/local/bin/docker-compose
- name: Test devcontainer sqlite3
uses: devcontainers/ci@v0.3
with:

@ -1,3 +1,5 @@
name: "<%= app_name %>"
services:
rails-app:
build:

@ -1295,6 +1295,8 @@ def test_devcontainer
assert_match(/ARG RUBY_VERSION=#{RUBY_VERSION}/, content)
end
assert_compose_file do |compose_config|
assert_equal "my_app", compose_config["name"]
expected_rails_app_config = {
"build" => {
"context" => "..",