Inline anemic methods

2019-05-15 15:53:43 -04:00 · 2019-05-15 15:53:43 -04:00 · 5f50f4d63b
commit 5f50f4d63b
parent 13d6aa3a7b
1 changed files with 4 additions and 10 deletions
--- a/activestorage/app/models/active_storage/variant.rb
+++ b/activestorage/app/models/active_storage/variant.rb
@ -96,19 +96,13 @@ def processed?
    end

    def process
-      blob.open do |image|
-        transform(image) { |output| upload(output) }
+      blob.open do |input|
+        variation.transform(input, format: format) do |output|
+          service.upload(key, output)
+        end
      end
    end

-    def transform(image, &block)
-      variation.transform(image, format: format, &block)
-    end
-
-    def upload(file)
-      service.upload(key, file)
-    end
-

    def specification
      @specification ||=