Mark internal cache constants as private

Closes #14640
2016-12-31 10:05:46 +10:30 · 2016-12-31 10:05:46 +10:30 · 64e5b897ac
commit 64e5b897ac
parent 6b126ffdcd
1 changed files with 4 additions and 1 deletions
--- a/activerecord/lib/active_record/relation/delegation.rb
+++ b/activerecord/lib/active_record/relation/delegation.rb
@ -15,7 +15,10 @@ def initialize_relation_delegate_cache
          delegate = Class.new(klass) {
            include ClassSpecificRelation
          }
-          const_set klass.name.gsub("::".freeze, "_".freeze), delegate
+          mangled_name = klass.name.gsub("::".freeze, "_".freeze)
+          const_set mangled_name, delegate
+          private_constant mangled_name
+
          cache[klass] = delegate
        end
      end