TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Use #model_name on instances instead of classes

Browse Source 
This allows rails code to be more confdent when asking for a model name, instead of having to ask for the class.

Rails core discussion here: https://groups.google.com/forum/#!topic/rubyonrails-core/ThSaXw9y1F8
This commit is contained in:
Amiel Martin 2014-06-20 15:49:27 -07:00
parent 5b23e31771
commit 6b0e834a19
13 changed files with 28 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actionpack/lib/action_controller/model_naming.rb
View File

@ -6,7 +6,7 @@ def convert_to_model(object)
end
def model_name_from_record_or_class(record_or_class)
(record_or_class.is_a?(Class) ? record_or_class : convert_to_model(record_or_class).class).model_name
convert_to_model(record_or_class).model_name
end
end
end

10
actionpack/lib/action_dispatch/routing/polymorphic_routes.rb
View File

@ -249,9 +249,9 @@ def handle_model(record)
model = record.to_model
name = if record.persisted?
args << model
model.class.model_name.singular_route_key
model.model_name.singular_route_key
else
@key_strategy.call model.class.model_name
@key_strategy.call model.model_name
end
named_route = prefix + "#{name}_#{suffix}"
@ -279,7 +279,7 @@ def handle_list(list)
parent.model_name.singular_route_key
else
args << parent.to_model
parent.to_model.class.model_name.singular_route_key
parent.to_model.model_name.singular_route_key
end
}
@ -292,9 +292,9 @@ def handle_list(list)
else
if record.persisted?
args << record.to_model
record.to_model.class.model_name.singular_route_key
record.to_model.model_name.singular_route_key
else
@key_strategy.call record.to_model.class.model_name
@key_strategy.call record.to_model.model_name
end
end

4
actionview/lib/action_view/helpers/form_helper.rb
View File

@ -1815,8 +1815,8 @@ def submit_default_value
object = convert_to_model(@object)
key = object ? (object.persisted? ? :update : :create) : :submit
model = if object.class.respond_to?(:model_name)
object.class.model_name.human
model = if object.respond_to?(:model_name)
object.model_name.human
else
@object_name.to_s.humanize
end

2
actionview/lib/action_view/helpers/tags/label.rb
View File

@ -40,7 +40,7 @@ def render(&block)
@object_name.gsub!(/\[(.*)_attributes\]\[\d+\]/, '.\1')
if object.respond_to?(:to_model)
key = object.class.model_name.i18n_key
key = object.model_name.i18n_key
i18n_default = ["#{key}.#{method_and_value}".to_sym, ""]
end

2
actionview/lib/action_view/model_naming.rb
View File

@ -6,7 +6,7 @@ def convert_to_model(object)
end
def model_name_from_record_or_class(record_or_class)
(record_or_class.is_a?(Class) ? record_or_class : convert_to_model(record_or_class).class).model_name
convert_to_model(record_or_class).model_name
end
end
end

4
actionview/test/activerecord/polymorphic_routes_test.rb
View File

@ -34,8 +34,8 @@ def to_model
end
class ModelDelegate
def self.model_name
ActiveModel::Name.new(self)
def model_name
ActiveModel::Name.new(self.class)
end
def to_param

2
activemodel/lib/active_model/errors.rb
View File

@ -434,7 +434,7 @@ def generate_message(attribute, type = :invalid, options = {})
options = {
default: defaults,
model: @base.class.model_name.human,
model: @base.model_name.human,
attribute: @base.class.human_attribute_name(attribute),
value: value
}.merge!(options)

11
activemodel/lib/active_model/lint.rb
View File

@ -73,16 +73,19 @@ def test_persisted?
# == \Naming
#
# Model.model_name must return a string with some convenience methods:
# <tt>:human</tt>, <tt>:singular</tt> and <tt>:plural</tt>. Check
# ActiveModel::Naming for more information.
# Model.model_name and Model#model_name must return a string with some
# convenience methods: # <tt>:human</tt>, <tt>:singular</tt> and
# <tt>:plural</tt>. Check ActiveModel::Naming for more information.
def test_model_naming
assert model.class.respond_to?(:model_name), "The model should respond to model_name"
assert model.class.respond_to?(:model_name), "The model class should respond to model_name"
model_name = model.class.model_name
assert model_name.respond_to?(:to_str)
assert model_name.human.respond_to?(:to_str)
assert model_name.singular.respond_to?(:to_str)
assert model_name.plural.respond_to?(:to_str)
assert model.respond_to?(:model_name), "The model instance should respond to model_name"
assert_equal model.model_name, model.class.model_name
end
# == \Errors Testing

2
activemodel/lib/active_model/naming.rb
View File

@ -308,7 +308,7 @@ def self.model_name_from_record_or_class(record_or_class) #:nodoc:
if record_or_class.respond_to?(:model_name)
record_or_class.model_name
elsif record_or_class.respond_to?(:to_model)
record_or_class.to_model.class.model_name
record_or_class.to_model.model_name
else
record_or_class.class.model_name
end

2
activemodel/lib/active_model/serializers/json.rb
View File

@ -93,7 +93,7 @@ def as_json(options = nil)
end
if root
root = self.class.model_name.element if root == true
root = model_name.element if root == true
{ root => serializable_hash(options) }
else
serializable_hash(options)

2
activemodel/lib/active_model/serializers/xml.rb
View File

@ -84,7 +84,7 @@ def serialize
@builder = options[:builder]
@builder.instruct! unless options[:skip_instruct]
root = (options[:root] || @serializable.class.model_name.element).to_s
root = (options[:root] || @serializable.model_name.element).to_s
root = ActiveSupport::XmlMini.rename_key(root, options)
args = [root]

1
activemodel/lib/active_model/validations.rb
View File

@ -39,6 +39,7 @@ module Validations
extend ActiveSupport::Concern
included do
extend ActiveModel::Naming
extend ActiveModel::Callbacks
extend ActiveModel::Translation

8
activerecord/lib/active_record/integration.rb
View File

@ -55,16 +55,16 @@ def to_param
def cache_key(*timestamp_names)
case
when new_record?
"#{self.class.model_name.cache_key}/new"
"#{model_name.cache_key}/new"
when timestamp_names.any?
timestamp = max_updated_column_timestamp(timestamp_names)
timestamp = timestamp.utc.to_s(cache_timestamp_format)
"#{self.class.model_name.cache_key}/#{id}-#{timestamp}"
"#{model_name.cache_key}/#{id}-#{timestamp}"
when timestamp = max_updated_column_timestamp
timestamp = timestamp.utc.to_s(cache_timestamp_format)
"#{self.class.model_name.cache_key}/#{id}-#{timestamp}"
"#{model_name.cache_key}/#{id}-#{timestamp}"
else
"#{self.class.model_name.cache_key}/#{id}"
"#{model_name.cache_key}/#{id}"
end
end