users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!
Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
This commit is contained in:
parent
c27883c501
commit
6ffb29d24e
@ -51,3 +51,8 @@ def jruby_skip(message = '')
|
||||
end
|
||||
|
||||
require 'mocha/setup' # FIXME: stop using mocha
|
||||
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
require 'active_support/test_case'
|
||||
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
|
||||
|
@ -497,3 +497,8 @@ def shutdown
|
||||
# Use N processes (N defaults to 4)
|
||||
Minitest.parallel_executor = ForkingExecutor.new(PROCESS_COUNT)
|
||||
end
|
||||
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
require 'active_support/test_case'
|
||||
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
|
||||
|
@ -340,3 +340,8 @@ def jruby_skip(message = '')
|
||||
end
|
||||
|
||||
require 'mocha/setup' # FIXME: stop using mocha
|
||||
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
require 'active_support/test_case'
|
||||
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
|
||||
|
@ -13,3 +13,8 @@
|
||||
require 'active_support/testing/autorun'
|
||||
|
||||
require 'mocha/setup' # FIXME: stop using mocha
|
||||
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
require 'active_support/test_case'
|
||||
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
|
||||
|
@ -201,3 +201,8 @@ def in_time_zone(zone)
|
||||
end
|
||||
|
||||
require 'mocha/setup' # FIXME: stop using mocha
|
||||
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
require 'active_support/test_case'
|
||||
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
|
||||
|
@ -22,10 +22,6 @@ def self.for_tag(tag)
|
||||
yield if $tags[tag]
|
||||
end
|
||||
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
self.i_suck_and_my_tests_are_order_dependent!
|
||||
|
||||
include ActiveSupport::Testing::TaggedLogging
|
||||
include ActiveSupport::Testing::SetupAndTeardown
|
||||
include ActiveSupport::Testing::Assertions
|
||||
|
@ -38,3 +38,8 @@ def jruby_skip(message = '')
|
||||
end
|
||||
|
||||
require 'mocha/setup' # FIXME: stop using mocha
|
||||
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
require 'active_support/test_case'
|
||||
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
|
||||
|
@ -28,6 +28,10 @@ def jruby_skip(message = '')
|
||||
end
|
||||
|
||||
class ActiveSupport::TestCase
|
||||
# FIXME: we have tests that depend on run order, we should fix that and
|
||||
# remove this method call.
|
||||
self.i_suck_and_my_tests_are_order_dependent!
|
||||
|
||||
private
|
||||
|
||||
unless defined?(:capture)
|
||||
|
Loading…
Reference in New Issue
Block a user