Merge pull request #36758 from jturkel/feature/hash-optimization

Avoid unnecessary hash allocation in HashWithIndifferentAccess#convert_value
2019-07-25 14:25:50 -04:00 · 2019-07-25 14:25:50 -04:00 · 706ee3eb49
commit 706ee3eb49
parent 8ff7efef6c 9318810142
1 changed files with 3 additions and 1 deletions
--- a/activesupport/lib/active_support/hash_with_indifferent_access.rb
+++ b/activesupport/lib/active_support/hash_with_indifferent_access.rb
@ -367,7 +367,9 @@ def convert_key(key) # :doc:
        key.kind_of?(Symbol) ? key.to_s : key
      end

-      def convert_value(value, options = {}) # :doc:
+      EMPTY_HASH = {}.freeze
+
+      def convert_value(value, options = EMPTY_HASH) # :doc:
        if value.is_a? Hash
          if options[:for] == :to_hash
            value.to_hash