TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

remove ancient TODOs [ci skip].

Browse Source
This commit is contained in:
Yves Senn 2013-03-18 08:25:18 +01:00
parent c4a7c31581
commit 85261a5e96
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actionpack/test/controller/output_escaping_test.rb
View File

@ -11,8 +11,6 @@ class OutputEscapingTest < ActiveSupport::TestCase
end end
test "escapeHTML shouldn't touch explicitly safe strings" do test "escapeHTML shouldn't touch explicitly safe strings" do
# TODO this seems easier to compose and reason about, but
# this should be verified
assert_equal "<", ERB::Util.h("<".html_safe) assert_equal "<", ERB::Util.h("<".html_safe)
end end

1
actionpack/test/template/url_helper_test.rb
View File

@ -51,7 +51,6 @@ def test_url_for_with_back_and_no_referer
assert_equal 'javascript:history.back()', url_for(:back) assert_equal 'javascript:history.back()', url_for(:back)
end end
# TODO: missing test cases
def test_button_to_with_straight_url def test_button_to_with_straight_url
assert_dom_equal %{<form method="post" action="http://www.example.com" class="button_to"><div><input type="submit" value="Hello" /></div></form>}, button_to("Hello", "http://www.example.com") assert_dom_equal %{<form method="post" action="http://www.example.com" class="button_to"><div><input type="submit" value="Hello" /></div></form>}, button_to("Hello", "http://www.example.com")
end end

3
activerecord/test/cases/locking_test.rb
View File

@ -341,9 +341,6 @@ def counter_test(model, expected_count)
# is so cumbersome. Will deadlock Ruby threads if the underlying db.execute # is so cumbersome. Will deadlock Ruby threads if the underlying db.execute
# blocks, so separate script called by Kernel#system is needed. # blocks, so separate script called by Kernel#system is needed.
# (See exec vs. async_exec in the PostgreSQL adapter.) # (See exec vs. async_exec in the PostgreSQL adapter.)
# TODO: The Sybase, and OpenBase adapters currently have no support for pessimistic locking
unless current_adapter?(:SybaseAdapter, :OpenBaseAdapter) || in_memory_db? unless current_adapter?(:SybaseAdapter, :OpenBaseAdapter) || in_memory_db?
class PessimisticLockingTest < ActiveRecord::TestCase class PessimisticLockingTest < ActiveRecord::TestCase
self.use_transactional_fixtures = false self.use_transactional_fixtures = false