TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #49299 from BuonOmo/loosen-arel-test

Browse Source 
Loosen test condition `Arel::Nodes::Node` descendants
This commit is contained in:
Jean Boussier 2023-09-16 20:45:01 +02:00 committed by GitHub
commit 8bd463c0b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
activerecord/test/cases/arel/nodes_test.rb
View File

@ -16,11 +16,12 @@ def test_every_arel_nodes_have_hash_eql_eqeq_from_same_class
node_descendants.delete(Arel::Nodes::NodeExpression)
bad_node_descendants = node_descendants.reject do |subnode|
eqeq_owner = subnode.instance_method(:==).owner
eqeq_method = subnode.instance_method(:==)
eqeq_owner = eqeq_method.owner
eql_owner = subnode.instance_method(:eql?).owner
hash_owner = subnode.instance_method(:hash).owner
eqeq_owner < Arel::Nodes::Node &&
eqeq_method.super_method && # Not using the ruby default #== method
eqeq_owner == eql_owner &&
eqeq_owner == hash_owner
end