- Added test for verifying that we treat line number indications from irb as user/lib code
- Cleaned up backtrace cleaner test code and removed instaces variables
This commit is contained in:
parent
1eb358299c
commit
8e1714b2f5
@ -1,24 +1,32 @@
|
|||||||
require 'abstract_unit'
|
require 'abstract_unit'
|
||||||
require 'rails/backtrace_cleaner'
|
require 'rails/backtrace_cleaner'
|
||||||
|
|
||||||
class BacktraceCleanerVendorGemTest < ActiveSupport::TestCase
|
class BacktraceCleanerTest < ActiveSupport::TestCase
|
||||||
def setup
|
def setup
|
||||||
@cleaner = Rails::BacktraceCleaner.new
|
@cleaner = Rails::BacktraceCleaner.new
|
||||||
end
|
end
|
||||||
|
|
||||||
test "should format installed gems correctly" do
|
test "should format installed gems correctly" do
|
||||||
@backtrace = [ "#{Gem.path[0]}/gems/nosuchgem-1.2.3/lib/foo.rb" ]
|
backtrace = [ "#{Gem.path[0]}/gems/nosuchgem-1.2.3/lib/foo.rb" ]
|
||||||
@result = @cleaner.clean(@backtrace, :all)
|
result = @cleaner.clean(backtrace, :all)
|
||||||
assert_equal "nosuchgem (1.2.3) lib/foo.rb", @result[0]
|
assert_equal "nosuchgem (1.2.3) lib/foo.rb", result[0]
|
||||||
end
|
end
|
||||||
|
|
||||||
test "should format installed gems not in Gem.default_dir correctly" do
|
test "should format installed gems not in Gem.default_dir correctly" do
|
||||||
@target_dir = Gem.path.detect { |p| p != Gem.default_dir }
|
target_dir = Gem.path.detect { |p| p != Gem.default_dir }
|
||||||
# skip this test if default_dir is the only directory on Gem.path
|
# skip this test if default_dir is the only directory on Gem.path
|
||||||
if @target_dir
|
if @target_dir
|
||||||
@backtrace = [ "#{@target_dir}/gems/nosuchgem-1.2.3/lib/foo.rb" ]
|
backtrace = [ "#{target_dir}/gems/nosuchgem-1.2.3/lib/foo.rb" ]
|
||||||
@result = @cleaner.clean(@backtrace, :all)
|
result = @cleaner.clean(backtrace, :all)
|
||||||
assert_equal "nosuchgem (1.2.3) lib/foo.rb", @result[0]
|
assert_equal "nosuchgem (1.2.3) lib/foo.rb", result[0]
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "should consider traces from irb lines as User code" do
|
||||||
|
backtrace = [ "from (irb):1",
|
||||||
|
"from /Path/to/rails/railties/lib/rails/commands/console.rb:77:in `start'",
|
||||||
|
"from bin/rails:4:in `<main>'" ]
|
||||||
|
result = @cleaner.clean(backtrace, :all)
|
||||||
|
assert_equal "from (irb):1", result[0]
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
Loading…
Reference in New Issue
Block a user