TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #51939 from ElMassimo/fix-broadcast-logger-compatibility

Browse Source 
Improve compatibility for `ActiveSupport::BroadcastLogger`
This commit is contained in:
Rafael Mendonça França 2024-05-30 14:32:40 -04:00 committed by GitHub
commit 91a441b650
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
activesupport/lib/active_support/broadcast_logger.rb
View File

@ -229,6 +229,7 @@ def initialize_copy(other)
private private
def dispatch(&block) def dispatch(&block)
@broadcasts.each { |logger| block.call(logger) } @broadcasts.each { |logger| block.call(logger) }
true
end end
def method_missing(name, ...) def method_missing(name, ...)

5
activesupport/test/broadcast_logger_test.rb
View File

@ -302,6 +302,11 @@ def info(msg, &block)
assert_same logger, broadcast_logger.broadcasts.sole assert_same logger, broadcast_logger.broadcasts.sole
end end
test "logging always returns true" do
assert_equal true, @logger.info("Hello")
assert_equal true, @logger.error("Hello")
end
class CustomLogger class CustomLogger
attr_reader :adds, :closed, :chevrons attr_reader :adds, :closed, :chevrons
attr_accessor :level, :progname, :formatter, :local_level attr_accessor :level, :progname, :formatter, :local_level