TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Reuse view_context_class when possible

Browse Source 
The generated view context classes tend to be fairly complex and use a
lot of memory. Similar to how we only generate new helper classes when
necessary (see https://github.com/rails/rails/pull/40204) we should be
doing the same for view context classes.
This commit is contained in:
John Hawthorn 2021-12-13 15:43:39 -08:00
parent 6fb54c00e4
commit 94643fde8f
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
actionview/lib/action_view/rendering.rb
View File

@ -48,7 +48,18 @@ def _routes
def _helpers
end
def inherit_view_context_class?
superclass.respond_to?(:view_context_class) &&
supports_path? == superclass.supports_path? &&
_routes.equal?(superclass._routes) &&
_helpers.equal?(superclass._helpers)
end
def build_view_context_class(klass, supports_path, routes, helpers)
if inherit_view_context_class?
return superclass.view_context_class
end
Class.new(klass) do
if routes
include routes.url_helpers(supports_path)