TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Changed id-writer to save join table records based on association primary key #20995

Browse Source 
Changed id-writer to save join table records based on association primary key
This commit is contained in:
Himesh 2015-07-23 15:49:22 +05:30 committed by Arthur Neves
parent 0e189cb3df
commit 9c9fb19b9e
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
activerecord/lib/active_record/associations/collection_association.rb
View File

@ -72,7 +72,10 @@ def ids_writer(ids)
pk_type = reflection.primary_key_type
ids = Array(ids).reject(&:blank?)
ids.map! { |i| pk_type.cast(i) }
replace(klass.find(ids).index_by(&:id).values_at(*ids))
records = klass.where(reflection.association_primary_key => ids).index_by do |r|
r.send(reflection.association_primary_key)
end.values_at(*ids)
replace(records)
end
def reset

2
activerecord/test/cases/associations/has_many_through_associations_test.rb
View File

@ -882,7 +882,7 @@ def test_collection_singular_ids_setter_with_string_primary_keys
def test_collection_singular_ids_setter_raises_exception_when_invalid_ids_set
company = companies(:rails_core)
ids = [Developer.first.id, -9999]
assert_raises(ActiveRecord::RecordNotFound) {company.developer_ids= ids}
assert_raises(ActiveRecord::AssociationTypeMismatch) {company.developer_ids= ids}
end
def test_build_a_model_from_hm_through_association_with_where_clause