TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix migrations compatibility for default precision value on datetime columns

Browse Source
This commit is contained in:
Roberto Miranda 2021-06-25 17:44:33 +01:00
parent 9b9d9c7bf9
commit 9e3320ad26
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
activerecord/lib/active_record/migration/compatibility.rb
View File

@ -48,6 +48,10 @@ def self.compatible_timestamp_type(type, connection)
end
def add_column(table_name, column_name, type, **options)
if type == :datetime
options[:precision] ||= nil
end
type = PostgreSQLCompat.compatible_timestamp_type(type, connection)
super
end
@ -65,6 +69,11 @@ def new_column_definition(name, type, **options)
type = PostgreSQLCompat.compatible_timestamp_type(type, @conn)
super
end
def column(name, type, index: nil, **options)
options[:precision] ||= nil
super
end
end
private
@ -265,6 +274,8 @@ def add_column(table_name, column_name, type, **options)
if type == :primary_key
type = :integer
options[:primary_key] = true
elsif type == :datetime
options[:precision] ||= nil
end
super
end
@ -295,11 +306,6 @@ def timestamps(**options)
options[:null] = true if options[:null].nil?
super
end
def column(name, type, index: nil, **options)
options[:precision] ||= nil
super
end
end
def add_reference(table_name, ref_name, **options)
@ -329,14 +335,6 @@ def remove_index(table_name, column_name = nil, **options)
super
end
def add_column(table_name, column_name, type, **options)
if type == :datetime
options[:precision] ||= nil
end
super
end
private
def compatible_table_definition(t)
class << t