TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

attr_accessor_with_default should raise an ArgumentError not a RuntimeError

Browse Source
This commit is contained in:
Aaron Patterson 2010-09-24 14:48:25 -07:00
parent a348ffcb2d
commit a0db7be4af
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
activesupport/lib/active_support/core_ext/module/attr_accessor_with_default.rb
View File

@ -18,9 +18,8 @@ class Module
#
# attr_accessor_with_default(:element_name) { name.underscore }
#
def attr_accessor_with_default(sym, default = nil, &block)
raise 'Default value or block required' unless !default.nil? || block
define_method(sym, block_given? ? block : Proc.new { default })
def attr_accessor_with_default(sym, default = Proc.new)
define_method(sym, block_given? ? default : Proc.new { default })
module_eval(<<-EVAL, __FILE__, __LINE__ + 1)
def #{sym}=(value) # def age=(value)
class << self; attr_reader :#{sym} end # class << self; attr_reader :age end

2
activesupport/test/core_ext/module/attr_accessor_with_default_test.rb
View File

@ -26,6 +26,6 @@ def test_default_proc
end
def test_invalid_args
assert_raise(RuntimeError) {@target.attr_accessor_with_default :foo}
assert_raise(ArgumentError) {@target.attr_accessor_with_default :foo}
end
end