TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Revert "prevent minitest from printing a --seed run option"

Browse Source 
Reason: on a second thought, minitest prints a seed as run option
regardless of the test order, and it actually calls srand, so
albeit it might be misleading I believe, it is the way it is and
should be left that way.

This reverts commit c15862ae0cb876d745609170f0f90a9bb9b5e0ae.
This commit is contained in:
Xavier Noria 2013-02-24 01:22:45 +01:00
parent c15862ae0c
commit a628dd5ac4
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
activesupport/lib/active_support/test_case.rb
View File

@ -16,16 +16,6 @@
rescue LoadError
end
# FIXME: We force sorted test order below, but minitest includes --seed SEED in
# the printed run options, which could be misleading, since users could assume
# from that trace that tests are being randomized.
MiniTest::Unit.class_eval do
alias original_help help
def help
original_help.sub(/--seed\s+\d+\s*/, '')
end
end
module ActiveSupport
class TestCase < ::MiniTest::Unit::TestCase
Assertion = MiniTest::Assertion
@ -36,8 +26,8 @@ def self.for_tag(tag)
yield if $tags[tag]
end
# FIXME: We have tests that depend on run order, we should fix that and
# remove this method (and remove the MiniTest::Unit help hack above).
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method.
def self.test_order # :nodoc:
:sorted
end