Merge pull request #42764 from jhawthorn/logger_thread_safe_fiber_local

Avoid using class var in LoggerThreadSafeLevel
This commit is contained in:
John Hawthorn 2021-07-13 10:54:15 -07:00 committed by GitHub
commit a8a54a1821
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -9,10 +9,6 @@ module ActiveSupport
module LoggerThreadSafeLevel # :nodoc:
extend ActiveSupport::Concern
included do
cattr_accessor :local_levels, default: Concurrent::Map.new(initial_capacity: 2), instance_accessor: false
end
Logger::Severity.constants.each do |severity|
class_eval(<<-EOT, __FILE__, __LINE__ + 1)
def #{severity.downcase}? # def debug?
@ -21,25 +17,21 @@ def #{severity.downcase}? # def debug?
EOT
end
def local_log_id
Fiber.current.__id__
end
def local_level
self.class.local_levels[local_log_id]
# Note: Thread#[] is fiber-local
Thread.current[:logger_thread_safe_level]
end
def local_level=(level)
case level
when Integer
self.class.local_levels[local_log_id] = level
when Symbol
self.class.local_levels[local_log_id] = Logger::Severity.const_get(level.to_s.upcase)
level = Logger::Severity.const_get(level.to_s.upcase)
when nil
self.class.local_levels.delete(local_log_id)
else
raise ArgumentError, "Invalid log level: #{level.inspect}"
end
Thread.current[:logger_thread_safe_level] = level
end
def level