Merge pull request #32386 from utilum/tmpname_basename

Fix: FileStoreTest#test_filename_max_size fails in Ruby 2.5.1
This commit is contained in:
Andrew White 2018-03-31 14:42:20 +01:00
commit b1a0ab179f
No known key found for this signature in database
GPG Key ID: 7E83729F16B086CF

@ -68,7 +68,9 @@ def test_key_transformation_with_pathname
def test_filename_max_size
key = "#{'A' * ActiveSupport::Cache::FileStore::FILENAME_MAX_SIZE}"
path = @cache.send(:normalize_key, key, {})
Dir::Tmpname.create(path) do |tmpname, n, opts|
basename = File.basename(path)
dirname = File.dirname(path)
Dir::Tmpname.create(basename, Dir.tmpdir + dirname) do |tmpname, n, opts|
assert File.basename(tmpname + ".lock").length <= 255, "Temp filename too long: #{File.basename(tmpname + '.lock').length}"
end
end