TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix a bug where symbols and strings were not behaving the same in the router. [#5431 state:resolved]

Browse Source
This commit is contained in:
José Valim 2010-08-24 10:09:06 -03:00
parent 2fb0cbec02
commit b4f304b7b6
2 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
actionpack/lib/action_dispatch/routing/mapper.rb
View File

@ -726,22 +726,17 @@ def match(*args)
path = options.delete(:path)
action = args.first
if action.is_a?(Symbol)
if action && action.to_s =~ /^[\w_]+$/
path = path_for_action(action, path)
options[:to] ||= action
options[:as] = name_for_action(action, options[:as])
options[:action] ||= action
options[:as] = name_for_action(action, options[:as])
with_exclusive_scope do
return super(path, options)
end
elsif resource_method_scope?
path = path_for_custom_action
if action =~ /^[a-zA-Z][_a-zA-Z0-9]*$/
options[:action] ||= action
options[:as] = name_for_action(action, options[:as])
else
options[:as] = name_for_action(options[:as]) if options[:as]
end
options[:as] = name_for_action(options[:as]) if options[:as]
args.push(options)
with_exclusive_scope do

6
actionpack/test/dispatch/routing_test.rb
View File

@ -658,7 +658,7 @@ def test_bookmarks
get '/bookmark/remove'
assert_equal 'bookmarks#destroy', @response.body
assert_equal '/bookmark/remove', bookmark_remove_path
assert_equal '/bookmark/remove', remove_bookmark_path
end
end
@ -1192,7 +1192,7 @@ def test_match_shorthand_with_no_scope
def test_match_shorthand_inside_namespace
with_test_routes do
assert_equal '/account/shorthand', account_shorthand_path
assert_equal '/account/shorthand', shorthand_account_path
get '/account/shorthand'
assert_equal 'account#shorthand', @response.body
end
@ -1244,7 +1244,7 @@ def test_redirect_with_port
def test_normalize_namespaced_matches
with_test_routes do
assert_equal '/account/description', account_description_path
assert_equal '/account/description', description_account_path
get '/account/description'
assert_equal 'account#description', @response.body