TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #48964 from sinsoku/fix-method-name

Browse Source 
Fix method name to `check_all_pending!`
This commit is contained in:
Eileen M. Uchitelle 2023-08-17 10:04:41 -04:00 committed by GitHub
commit b56f938b5f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
activerecord/CHANGELOG.md
View File

@ -283,9 +283,9 @@
*Jean Boussier*
* Deprecate `check_pending!` in favor of `check_pending_migrations!`.
* Deprecate `check_pending!` in favor of `check_all_pending!`.
`check_pending!` will only check for pending migrations on the current database connection or the one passed in. This has been deprecated in favor of `check_pending_migrations!` which will find all pending migrations for the database configurations in a given environment.
`check_pending!` will only check for pending migrations on the current database connection or the one passed in. This has been deprecated in favor of `check_all_pending!` which will find all pending migrations for the database configurations in a given environment.
*Eileen M. Uchitelle*

4
activerecord/lib/active_record/migration.rb
View File

@ -644,10 +644,10 @@ def nearest_delegate # :nodoc:
# Raises ActiveRecord::PendingMigrationError error if any migrations are pending.
#
# This is deprecated in favor of +check_pending_migrations!+
# This is deprecated in favor of +check_all_pending!+
def check_pending!(connection = ActiveRecord::Tasks::DatabaseTasks.migration_connection)
ActiveRecord.deprecator.warn(<<-MSG.squish)
The `check_pending!` method is deprecated in favor of `check_pending_migrations!`. The
The `check_pending!` method is deprecated in favor of `check_all_pending!`. The
new implementation will loop through all available database configurations and find
pending migrations. The prior implementation did not permit this.
MSG