stop exposing the exception class

This commit is contained in:
Aaron Patterson 2022-09-27 09:37:50 -07:00
parent 7b2f9328a6
commit bff868d56f
No known key found for this signature in database
GPG Key ID: 953170BCB4FFAFC6
5 changed files with 6 additions and 10 deletions

@ -139,7 +139,7 @@ def log_error(request, wrapper)
message = []
message << " "
message << "#{wrapper.exception_class} (#{wrapper.message}):"
message << "#{wrapper.exception_class_name} (#{wrapper.message}):"
message.concat(wrapper.annotated_source_code)
message << " "
message.concat(trace)

@ -41,7 +41,7 @@ class ExceptionWrapper
"ActionDispatch::Http::MimeNegotiation::InvalidType"
]
attr_reader :backtrace_cleaner, :wrapped_causes
attr_reader :backtrace_cleaner, :wrapped_causes, :exception_class_name
def initialize(backtrace_cleaner, exception)
@backtrace_cleaner = backtrace_cleaner
@ -72,10 +72,6 @@ def failures
@exception.failures
end
def exception_class
@exception.class
end
def has_corrections?
@exception.respond_to?(:original_message) && @exception.respond_to?(:corrections)
end

@ -4,7 +4,7 @@
<div class="actions">
<% actions.each do |action, _| %>
<%= button_to action, ActionDispatch::ActionableExceptions.endpoint, params: {
error: exception_wrapper.exception_class.name,
error: exception_wrapper.exception_class_name,
action: action,
location: request.path
} %>

@ -1,6 +1,6 @@
<header>
<h1>
<%= @exception_wrapper.exception_class.to_s %>
<%= @exception_wrapper.exception_class_name %>
<% if params_valid? && @request.parameters['controller'] %>
in <%= @request.parameters['controller'].camelize %>Controller<% if @request.parameters['action'] %>#<%= @request.parameters['action'] %><% end %>
<% end %>
@ -21,7 +21,7 @@
<% @exception_wrapper.wrapped_causes.each.with_index(1) do |wrapper, index| %>
<div class="details">
<a class="summary" href="#" onclick="return toggle(<%= wrapper.exception_id %>)">
<%= wrapper.exception_class.name %>: <%= h wrapper.message %>
<%= wrapper.exception_class_name %>: <%= h wrapper.message %>
</a>
</div>

@ -1,4 +1,4 @@
<%= @exception_wrapper.exception_class.to_s %><%
<%= @exception_wrapper.exception_class_name %><%
if params_valid? && @request.parameters['controller']
%> in <%= @request.parameters['controller'].camelize %>Controller<% if @request.parameters['action'] %>#<%= @request.parameters['action'] %><% end %>
<% end %>