TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Ensure that mini_magick is absent after rails new with --skip-active-storage

Browse Source 
Remove redundant assertions of an absence of `mini_magick` in `Gemfile`
since `bin/rails app:update` does not update Gemfile.
This assertions was added by 4a835aa3236eedb135ccf8b59ed3c03e040b8b01,
after reviewing of https://github.com/rails/rails/pull/32049 i realized
that assertions are redundant.
This commit is contained in:
bogdanvlviv 2018-02-20 01:02:10 +02:00
parent ffddaead04
commit c335066b9d
No known key found for this signature in database
GPG Key ID: E4ACD76A6DB6DFDD
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
railties/test/generators/app_generator_test.rb
View File

@ -315,6 +315,15 @@ def test_active_storage_mini_magick_gem
assert_file "Gemfile", /^# gem 'mini_magick'/
end
def test_mini_magick_gem_when_skip_active_storage_is_given
app_root = File.join(destination_root, "myapp")
run_generator [app_root, "--skip-active-storage"]
assert_file "#{app_root}/Gemfile" do |content|
assert_no_match(/gem 'mini_magick'/, content)
end
end
def test_app_update_does_not_generate_active_storage_contents_when_skip_active_storage_is_given
app_root = File.join(destination_root, "myapp")
run_generator [app_root, "--skip-active-storage"]
@ -336,10 +345,6 @@ def test_app_update_does_not_generate_active_storage_contents_when_skip_active_s
end
assert_no_file "#{app_root}/config/storage.yml"
assert_file "#{app_root}/Gemfile" do |content|
assert_no_match(/gem 'mini_magick'/, content)
end
end
def test_app_update_does_not_generate_active_storage_contents_when_skip_active_record_is_given
@ -363,10 +368,6 @@ def test_app_update_does_not_generate_active_storage_contents_when_skip_active_r
end
assert_no_file "#{app_root}/config/storage.yml"
assert_file "#{app_root}/Gemfile" do |content|
assert_no_match(/gem 'mini_magick'/, content)
end
end
def test_app_update_does_not_change_config_target_version