TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Update cookies helper on all HTTP requests

Browse Source 
Regression introduced by ae29142142324545a328948e059e8b8118fd7a33 / 8363b879fe759f0645179f4521cc64795efbee6e.

Previously, cookies were only updated on `GET` requests. Now we will
update the helper for all requests, as part of `process`. Added
regression tests for all available HTTP method helpers in
`ActionController::TestCase`.
This commit is contained in:
Jon Moss 2017-01-05 17:39:12 -05:00
parent 5f03172f54
commit c5da641471
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
actionpack/lib/action_controller/test_case.rb
View File

@ -389,9 +389,7 @@ def determine_default_controller_class(name)
# Note that the request method is not verified. The different methods are
# available to make the tests more expressive.
def get(action, **args)
res = process(action, method: "GET", **args)
cookies.update res.cookies
res
process(action, method: "GET", **args)
end
# Simulate a POST request with the given parameters and set/volley the response.
@ -519,6 +517,7 @@ def process(action, method: "GET", params: {}, session: nil, body: nil, flash: {
unless @request.cookie_jar.committed?
@request.cookie_jar.write(@response)
cookies.update(@request.cookie_jar.instance_variable_get(:@cookies))
cookies.update(@response.cookies)
end
end
@response.prepare!

9
actionpack/test/dispatch/cookies_test.rb
View File

@ -395,6 +395,15 @@ def test_deleted_cookie_predicate
assert_equal false, cookies.deleted?("another")
end
# Ensure all HTTP methods have their cookies updated
[:get, :post, :patch, :put, :delete, :head].each do |method|
define_method("test_deleting_cookie_#{method}") do
request.cookies[:user_name] = "Joe"
public_send method, :logout
assert_nil cookies[:user_name]
end
end
def test_deleted_cookie_predicate_with_mismatching_options
cookies[:user_name] = "Joe"
cookies.delete("user_name", path: "/path")